On Wed, Sep 6, 2023 at 4:50 AM Daniel Gustafsson <dan...@yesql.se> wrote: > > On 5 Sep 2023, at 17:29, Robert Haas <robertmh...@gmail.com> wrote: > > On Tue, Sep 5, 2023 at 8:12 AM Daniel Gustafsson <dan...@yesql.se> wrote: > > >> The attached version of the patch replaces it with a boolean flag for > >> turning > >> off all event triggers, and I also renamed it to the debug_xxx "GUC > >> namespace" > >> which seemed more appropriate. > > > > I don't care for the debug_xxx renaming, myself. I think that should > > be reserved for things where we believe there's no reason to ever use > > it in production/real life, or for things whose purpose is to emit > > debugging messages. Neither is the case here. > > Fair enough, how about disable_event_trigger instead as per the attached?
I usually prefer to give things a positive sense, talking about whether things are enabled rather than disabled. I'd do event_triggers = off | on, like we have for row_security. YMMV, though. -- Robert Haas EDB: http://www.enterprisedb.com
