> On 25 Sep 2023, at 01:35, Michael Paquier <mich...@paquier.xyz> wrote: > > On Fri, Sep 22, 2023 at 05:29:01PM +0200, Daniel Gustafsson wrote: >> Since the main driver for this is to reduce the usage/need for single-user >> mode >> I also reworded the patch slightly. Instead of phrasing this as an >> alternative >> to single-user mode, I reversed it such that single-user mode is an >> alternative >> to this GUC. > > Okay. > > + be disabled by setting it to <literal>false</literal>. Setting the > value > + to <literal>true</literal> will not disable any event triggers, this > > This uses a double negation. Perhaps just "Setting this value to true > allows all event triggers to run."
Fair enough, although I used "fire" instead of "run" which is consistent with the event trigger documentation. > 003_check_guc.pl has detected a failure because event_triggers is > missing in postgresql.conf.sample while it is not marked with > GUC_NOT_IN_SAMPLE anymore. > > Keeping the docs consistent with the sample file, I would suggest the > attached on top of your v9. Ah, yes. The attached v10 has the above to fixes. -- Daniel Gustafsson
v10-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch
Description: Binary data
