On Thu, Mar 28, 2024 at 2:49 AM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Wed, Mar 27, 2024 at 7:42 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > I think that there are two options to handle it: > > > > 1. change COPY grammar to accept DEFAULT as an option value. > > 2. change tab-completion to complement 'DEFAULT' instead of DEFAULT, > > and update the doc too. > > > > As for the documentation, we can add single-quotes as follows: > > > > ENCODING '<replaceable class="parameter">encoding_name</replaceable>' > > + LOG_VERBOSITY [ '<replaceable class="parameter">mode</replaceable>' ] > > > > I thought the option (2) is better but there seems no precedent of > > complementing a single-quoted string other than file names. So the > > option (1) could be clearer. > > > > What do you think? > > There is another option to change log_verbosity to {none, verbose} or > {none, skip_row_info} (discuseed here > https://www.postgresql.org/message-id/Zelrqq-pkfkvsjPn%40paquier.xyz > that we might extend this option to other use-cases in future). I tend > to agree with you to support log_verbose to be set to default without > quotes just to be consistent with other commands that allow that [1]. > And, thanks for quickly identifying where to change in the gram.y. > With that change, now I have changed all the new tests added to use > log_verbosity default without quotes. > > FWIW, a recent commit [2] did the same. Therefore, I don't see a > problem supporting it that way for COPY log_verbosity. > > Please find the attached v13 patch with the change.
Thank you for updating the patch quickly, and sharing the reference. I think {default, verbose} is a good start and more consistent with other similar features. We can add other modes later. Regarding the syntax change, since copy_generic_opt_arg rule is only for COPY option syntax, the change doesn't affect other syntaxes. I've confirmed the tab-completion works fine. I'll push the patch, barring any objections. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com