> On 16 May 2024, at 11:43, Peter Eisentraut <pe...@eisentraut.org> wrote:

> You might want to run your patch through pgperltidy.  The result doesn't look 
> bad, but a bit different than what you had crafted.

Ugh, I thought I had but clearly had forgotten. Fixed now.

> append_conf() opens and closes the file for each call.  It might be nice if 
> it could accept a list.  Or you can just pass the whole block as one string, 
> like it was done for pg_ident.conf before.

The attached v2 pass the whole block as a here-doc which seemed like the best
option to retain readability of the config.

--
Daniel Gustafsson

Attachment: v2-0002-Use-library-functions-to-edit-config-in-SSL-tests.patch
Description: Binary data

Attachment: v2-0001-Test-for-PG_TEST_EXTRA-separately.patch
Description: Binary data

Reply via email to