Hi, Minor comment: + if (errflag == true) + ereport(ERROR,
I think 'if (errflag)' should suffice. Cheers On Tue, Feb 9, 2021 at 10:44 AM Pavel Borisov <pashkin.e...@gmail.com> wrote: > вт, 9 февр. 2021 г. в 01:46, Mark Dilger <mark.dil...@enterprisedb.com>: > >> >> >> > On Feb 8, 2021, at 2:46 AM, Pavel Borisov <pashkin.e...@gmail.com> >> wrote: >> > >> > 0002 - is a temporary hack for testing. It will allow inserting >> duplicates in a table even if an index with the exact name "idx" has a >> unique constraint (generally it is prohibited to insert). Then a new >> amcheck will tell us about these duplicates. It's pity but testing can not >> be done automatically, as it needs a core recompile. For testing I'd >> recommend a protocol similar to the following: >> > >> > - Apply patch 0002 >> > - Set autovaccum = off in postgresql.conf >> >> Thanks Pavel and Anastasia for working on this! >> >> Updating pg_catalog directly is ugly, but the following seems a simpler >> way to set up a regression test than having to recompile. What do you >> think? >> >> Very nice idea, thanks! > I've made a regression test based on it. PFA v.2 of a patch. Now it > doesn't need anything external for testing. > > -- > Best regards, > Pavel Borisov > > Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> >
