Raymond Hettinger added the comment:

When reviewing AC patches, we should always compare the help() before and 
after.  

Also, if the code already had fast parsing like:
   if (!PyArg_UnpackTuple(args, "reversed", 1, 1, &seq) )
there needs to be a before and after timing to make sure there wasn't a 
performance regression.

When PyArg_NoKeywords was present, we need to verify that the AC version also 
precludes keyword arguments (to prevent the creation of unhelpful keyword args 
and to keep compatibility with other versions of Python).

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20186>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to