Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 )
Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15660/1/src/kudu/client/columnar_scan_batch.h File src/kudu/client/columnar_scan_batch.h: http://gerrit.cloudera.org:8080/#/c/15660/1/src/kudu/client/columnar_scan_batch.h@67 PS1, Line 67: Status GetFixedLengthColumn(int idx, Slice* data) const; > hm I suppose we could add a bunch of per-type APIs but since this is a pret Done http://gerrit.cloudera.org:8080/#/c/15660/1/src/kudu/common/columnar_serialization.h File src/kudu/common/columnar_serialization.h: http://gerrit.cloudera.org:8080/#/c/15660/1/src/kudu/common/columnar_serialization.h@38 PS1, Line 38: BINARY > nit: maybe be explicit about binary physical type. Done -- To view, visit http://gerrit.cloudera.org:8080/15660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadf728744feb83f5980e62bea4fd7634a1a52467 Gerrit-Change-Number: 15660 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 06 Apr 2020 19:45:19 +0000 Gerrit-HasComments: Yes
