Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 )
Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/client/scanner-internal.cc@836 PS3, Line 836: Slice* data > nit: the output parameter is modified even if the method returns non-OK sta Done http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/client/scanner-internal.cc@844 PS3, Line 844: resp_data_.columns(idx) > nit: maybe, introduce a reference variable for resp_data_.columns(idx) and Done http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/client/scanner-internal.cc@865 PS3, Line 865: offsets->size(), expected_size > The third parameter for Substitute() is missing? good catch! http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/15660/3/src/kudu/tserver/tablet_server-test.cc@2599 PS3, Line 2599: ASSERT_EQ(col_data.size(), (kNumRows + 1) * sizeof(uint32_t)); > nit: IIRC, in ASSERT_EQ() the expected value comes first; otherwise, it's h https://github.com/google/googletest/blob/master/googletest/docs/primer.md says: Historical note: Before February 2016 *_EQ had a convention of calling it as ASSERT_EQ(expected, actual), so lots of existing code uses this order. Now *_EQ treats both parameters in the same way. -- To view, visit http://gerrit.cloudera.org:8080/15660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadf728744feb83f5980e62bea4fd7634a1a52467 Gerrit-Change-Number: 15660 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 07 Apr 2020 20:40:06 +0000 Gerrit-HasComments: Yes
