Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 )
Change subject: Upgrade C++ to protobuf 3.12 ...................................................................... Patch Set 3: (1 comment) Looks like there is still an UBSAN failure that might need to be ignored too? http://gerrit.cloudera.org:8080/#/c/16135/3/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/16135/3/thirdparty/vars.sh@57 PS3, Line 57: PROTOBUF_VERSION=3.12.3 In this change (unmerged) I also changed the build to use the protobuf-cpp source instead of the full protobuf source to make thirdparty smaller. https://gerrit.cloudera.org/#/c/15939/ Think thats worth doing? -- To view, visit http://gerrit.cloudera.org:8080/16135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5e6bbdd2c517b1af2ff833701983315111bba4 Gerrit-Change-Number: 16135 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jul 2020 00:33:00 +0000 Gerrit-HasComments: Yes
