Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 )
Change subject: Upgrade C++ to protobuf 3.12 ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Thank you for this patch! http://gerrit.cloudera.org:8080/#/c/16135/4/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/16135/4/src/kudu/consensus/consensus_queue.cc@696 PS4, Line 696: LAGS_consensus_max_batch_size_bytes - request->ByteSizeLong(); > I'm afraid that's a behavioral change and don't want to let this "upgrade P Yep, this makes sense to me. I guess we can do that in a separate changelist. http://gerrit.cloudera.org:8080/#/c/16135/4/src/kudu/rpc/result_tracker.h File src/kudu/rpc/result_tracker.h: http://gerrit.cloudera.org:8080/#/c/16135/4/src/kudu/rpc/result_tracker.h@283 PS4, Line 283: int64_t > perhaps but I didn't want to make more changes than necessary here lest som Yup, that makes sense to me. We might address that in a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/16135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5e6bbdd2c517b1af2ff833701983315111bba4 Gerrit-Change-Number: 16135 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 07 Jul 2020 23:24:26 +0000 Gerrit-HasComments: Yes
