Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16137 )
Change subject: Optimize GetTableLocations for better arena use ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/ts_descriptor.cc@220 PS7, Line 220: CHECK > isn't it better to crash with CHECK failure than with a SIGSEGV though? What's the benefit crashing with SIGABRT vs SIGSEGV? A better reputation or something? :) As for the downsides, this is an extra instruction in a relatively hot path. It seems this is a protection against a programming error, and DCHECK() is good enough way to catch those. -- To view, visit http://gerrit.cloudera.org:8080/16137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea Gerrit-Change-Number: 16137 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Jul 2020 19:41:36 +0000 Gerrit-HasComments: Yes
