Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16137 )

Change subject: Optimize GetTableLocations for better arena use
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/ts_descriptor.cc
File src/kudu/master/ts_descriptor.cc:

http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/ts_descriptor.cc@220
PS7, Line 220: CHECK
> It's not about SIGABRT vs SIGSEGV, IIRC it's easier to debug CHECK failures
Ah, indeed: SIGABRT gives nice stack traces in the logs, agree.  You are right.



--
To view, visit http://gerrit.cloudera.org:8080/16137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea
Gerrit-Change-Number: 16137
Gerrit-PatchSet: 7
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jul 2020 17:01:46 +0000
Gerrit-HasComments: Yes

Reply via email to