Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/16249

to review the following change.


Change subject: rpc: Change InboundCall arena to 4kB by default
......................................................................

rpc: Change InboundCall arena to 4kB by default

This changes the initial block size of the protobuf::Arena used by
InboundCall to 4kb instead of the 256 byte default. This reduces the
number of allocations required per call significantly for larger
requests/responses.

Benchmarked with:

    $ KUDU_ALLOW_SLOW_TESTS=1  ./build/latest/bin/table_locations-itest \
      --gtest_filter=TableLocationsTest.GetTableLocationsBenchmark \
      --rpc_num_service_threads=32 \
      --benchmark_num_threads=48

Before: 59408 req/sec
After:  74787 req/sec (1.25x)

Change-Id: Id20a3cbb5c2da1b6bfc519d852b90687297d4739
---
M src/kudu/rpc/inbound_call.cc
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/16249/1
--
To view, visit http://gerrit.cloudera.org:8080/16249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id20a3cbb5c2da1b6bfc519d852b90687297d4739
Gerrit-Change-Number: 16249
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>

Reply via email to