Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16249 )
Change subject: rpc: Change InboundCall arena to 4kB by default ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16249/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16249/1//COMMIT_MSG@10 PS1, Line 10: 4kb instead of the 256 byte default > Could you add some colors why 4kb turned to be the best choice here? There wasn't much analysis to it - seemed like a good number that was still "not that big" but big enough that it would cut out a bunch of allocations (now a 4k request/response fits in one allocation whereas before it would take 5 (assuming 256 bytes and doubling allocations). I'll put something to this effect in the message. As for setting the arena size more precisely, I suppose you could do that for the incoming request, but you don't have any idea how big the response is when you create the arena, so not sure it's worth the effort (at least until we see a case of an RPC where it is) http://gerrit.cloudera.org:8080/#/c/16249/1//COMMIT_MSG@21 PS1, Line 21: Before: 59408 req/sec : After: 74787 req/sec (1.25x) > Out of curiosity, I ran the test for requests/responses which are small in yea, could be that it's not allocator-bound -- To view, visit http://gerrit.cloudera.org:8080/16249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20a3cbb5c2da1b6bfc519d852b90687297d4739 Gerrit-Change-Number: 16249 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 29 Jul 2020 22:00:22 +0000 Gerrit-HasComments: Yes
