HeartSaVioR commented on code in PR #45023:
URL: https://github.com/apache/spark/pull/45023#discussion_r1517209325
##########
python/pyspark/sql/datasource.py:
##########
@@ -298,6 +320,133 @@ def read(self, partition: InputPartition) ->
Iterator[Union[Tuple, Row]]:
...
+class DataSourceStreamReader(ABC):
+ """
+ A base class for streaming data source readers. Data source stream readers
are responsible
+ for outputting data from a streaming data source.
+
+ .. versionadded: 4.0.0
+ """
+
+ def initialOffset(self) -> dict:
Review Comment:
python will always fail in runtime, so it's more likely whichever error
message is better to understand...
But, I don't know, IDE could be the rescue. @HyukjinKwon Will IDE be able to
point out if we define this as abstract and implementation class does not
implement this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
