HyukjinKwon commented on code in PR #45023: URL: https://github.com/apache/spark/pull/45023#discussion_r1517348253
########## python/pyspark/sql/datasource.py: ########## @@ -298,6 +320,133 @@ def read(self, partition: InputPartition) -> Iterator[Union[Tuple, Row]]: ... +class DataSourceStreamReader(ABC): + """ + A base class for streaming data source readers. Data source stream readers are responsible + for outputting data from a streaming data source. + + .. versionadded: 4.0.0 + """ + + def initialOffset(self) -> dict: Review Comment: IDE seems not catching this case. Things are runtime as Jungtaek said so it'd be difficult to statically prevent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org