panbingkun commented on PR #46301: URL: https://github.com/apache/spark/pull/46301#issuecomment-2086553908
> @panbingkun Thanks for bringing this up. I check the current Spark java code: > > ``` > find . -name "*.java"|xargs grep "logInfo\|logWarn\|logError"|grep -v target|grep -v test > ``` > > and found no log4j usages. Is this for external systems? If yes, the external system should be able to use the current Logging trait as well, right? @gengliangwang Hmm..., let me give you some examples, eg: https://github.com/apache/spark/blob/9caa6f7f8b8e9d906bc4a565179687350bfc7bb3/core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java#L285-L290 https://github.com/apache/spark/blob/9caa6f7f8b8e9d906bc4a565179687350bfc7bb3/core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java#L395 https://github.com/apache/spark/blob/9caa6f7f8b8e9d906bc4a565179687350bfc7bb3/connector/spark-ganglia-lgpl/src/main/java/com/codahale/metrics/ganglia/GangliaReporter.java#L336 <img width="1396" alt="image" src="https://github.com/apache/spark/assets/15246973/a0ffb8b1-4665-4141-b203-e31b76a789df";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
