gengliangwang commented on PR #46301: URL: https://github.com/apache/spark/pull/46301#issuecomment-2087129607
@panbingkun I see. There are about 88 loggings with variables ``` find . -name "*.java"|xargs grep -i "logger.info\|logger.warn\|logger.error"|grep "{}"| grep -v target|grep -v test ``` Since all the logs are using `{}` as variable placeholders, shall we try following the approach `Sequence of Key-Value Pairs (Seq[(K, V)])` from the [SPIP](https://docs.google.com/document/d/1rATVGmFLNVLmtxSpWrEceYm7d-ocgu8ofhryVs4g3XU/edit?usp=sharing)? Also, I think we can reference the LogKey.scala in the java side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org