gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1585627091
##########
core/src/main/scala/org/apache/spark/storage/PushBasedFetchHelper.scala:
##########
@@ -246,8 +246,9 @@ private class PushBasedFetchHelper(
case Failure(throwable) =>
// If we see an exception with getting the local dirs for
push-merged-local blocks,
// we fallback to fetch the original blocks. We do not report block
fetch failure.
- logWarning(s"Error while fetching the merged dirs for
push-merged-local " +
- s"blocks: ${pushMergedLocalBlocks.mkString(", ")}. Fetch the
original blocks instead",
+ logWarning(log"Error while fetching the merged dirs for
push-merged-local " +
+ log"blocks: ${MDC(BLOCK_ID, pushMergedLocalBlocks.mkString(",
"))}. " +
Review Comment:
```suggestion
log"blocks: ${MDC(BLOCK_IDS, pushMergedLocalBlocks.mkString(",
"))}. " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
