gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1585620988
##########
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala:
##########
@@ -76,8 +76,9 @@ private[spark] class SortShuffleManager(conf: SparkConf)
extends ShuffleManager
if (!conf.getBoolean("spark.shuffle.spill", true)) {
logWarning(
- "spark.shuffle.spill was set to false, but this configuration is ignored
as of Spark 1.6+." +
- " Shuffle will continue to spill to disk when necessary.")
+ log"spark.shuffle.spill was set to false, " +
Review Comment:
We don't need this one
##########
core/src/main/scala/org/apache/spark/status/KVUtils.scala:
##########
@@ -96,7 +97,7 @@ private[spark] object KVUtils extends Logging {
val kvSerializer = serializer(conf, live)
val db = backend(conf, live) match {
case LEVELDB =>
- logWarning("The LEVELDB is deprecated. Please use ROCKSDB instead.")
+ logWarning(log"The LEVELDB is deprecated. Please use ROCKSDB instead.")
Review Comment:
We don't need this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
