viirya commented on code in PR #46273:
URL: https://github.com/apache/spark/pull/46273#discussion_r1586883895
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2410,6 +2413,26 @@ class AdaptiveQueryExecSuite
}
}
+ test("SPARK-48037: Fix SortShuffleWriter lacks shuffle write related metrics
" +
+ "resulting in potentially inaccurate data") {
+ withTable("t3") {
+ withSQLConf(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+ SQLConf.SHUFFLE_PARTITIONS.key -> "16777217") {
+ sql("CREATE TABLE t3 USING PARQUET AS SELECT id FROM range(2)")
+ val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(
+ """
+ |SELECT id, count(*)
+ |FROM t3
+ |GROUP BY id
+ |LIMIT 1
+ |""".stripMargin, skipCheckAnswer = true)
+ assert(findTopLevelLimit(plan).size == 1)
+ assert(findTopLevelLimit(adaptivePlan).size == 1)
Review Comment:
Hmm, this only verifies if there is specific operator (i.e., `Limit`) in the
query plan, how is it related to the metrics you want to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
