cxzl25 commented on code in PR #46273:
URL: https://github.com/apache/spark/pull/46273#discussion_r1587027095
##########
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala:
##########
@@ -710,7 +711,7 @@ private[spark] class ExternalSorter[K, V, C](
serializerManager,
serInstance,
blockId,
- context.taskMetrics().shuffleWriteMetrics,
Review Comment:
It may be `SQLShuffleWriteMetricsReporter`, which may not be the same as
`context.taskMetrics().shuffleWriteMetrics`.
https://github.com/apache/spark/blob/9e12bd7f2b40051f7540b14d85a3ea1f3e41f6a1/core/src/main/scala/org/apache/spark/shuffle/ShuffleWriteProcessor.scala#L51-L56
https://github.com/apache/spark/blob/9e12bd7f2b40051f7540b14d85a3ea1f3e41f6a1/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala#L449-L455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
