sahnib commented on code in PR #45376:
URL: https://github.com/apache/spark/pull/45376#discussion_r1591349451
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -331,6 +331,7 @@ class Analyzer(override val catalogManager: CatalogManager)
extends RuleExecutor
Seq(
ResolveWithCTE,
ExtractDistributedSequenceID) ++
+ Seq(ResolveUpdateEventTimeWatermarkColumn) ++
Review Comment:
@HeartSaVioR I have added the `ResolveUpdateEventTimeWatermarkColumn` after
all resolution rules. At this place, we are guaranteed (IIUC) to have resolved
the query plan and should be able to extract watermark delay from child nodes
of UpdateEventTimeWatermarkColumn. Let me know if you think otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
