sahnib commented on code in PR #45376: URL: https://github.com/apache/spark/pull/45376#discussion_r1592763066
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUpdateEventTimeWatermarkColumn.scala: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.sql.catalyst.plans.logical.{EventTimeWatermark, LogicalPlan, UpdateEventTimeWatermarkColumn} +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.errors.QueryCompilationErrors + +/** + * Extracts the watermark delay and adds it to the UpdateEventTimeWatermarkColumn + * logical node (if such a node is present). [[UpdateEventTimeWatermarkColumn]] node updates + * the eventTimeColumn for upstream operators. + * + * If the logical plan contains a [[UpdateEventTimeWatermarkColumn]] node, but no watermark + * has been defined, the query will fail with a compilation error. + */ +object ResolveUpdateEventTimeWatermarkColumn extends Rule[LogicalPlan] { + + override def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsDown { + case u: UpdateEventTimeWatermarkColumn => Review Comment: Done. ########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala: ########## @@ -347,6 +347,28 @@ class IncrementalExecution( eventTimeWatermarkForEviction = inputWatermarkForEviction(m.stateInfo.get) ) + // UpdateEventTimeColumnExec is used to tag the eventTime column, and validate + // emitted rows adhere to watermark in the output of transformWithState. + // Hence, this node shares the same watermark value as TransformWithStateExec. + // However, given that UpdateEventTimeColumnExec does not store any state, it + // does not have any StateInfo. We simply use the StateInfo of transformWithStateExec + // to propagate watermark to both UpdateEventTimeColumnExec and transformWithStateExec. + case UpdateEventTimeColumnExec(eventTime, delay, None, + SerializeFromObjectExec(serializer, + t: TransformWithStateExec)) if t.stateInfo.isDefined => + + val stateInfo = t.stateInfo.get + val eventTimeWatermarkForLateEvents = inputWatermarkForLateEvents(stateInfo) + val eventTimeWatermarkForEviction = inputWatermarkForLateEvents(stateInfo) Review Comment: Renamed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
