Github user jaceklaskowski commented on the pull request: https://github.com/apache/spark/pull/10433#issuecomment-166618819 I disagree since Spark core is hard due to what it does and making it harder can hinder contributions. There are just such little things that can change how welcoming the code is. Please reconsider your vote (I spent the time on it already so if it's lost aka "I don't think this is worth it", let's turn it back when the change hits master). You've just agreed that the logic is convoluted.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org