Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/10433#issuecomment-166628562
Doh, you're *again* inviting me to make more involved changes (which is
great, but don't think helps others to contribute). What I'm gonna do is to
improve the change with changes with `TaskState`. Would that make sense? Would
you approve such a change? I know the code quite well now, and believe that it
needs such small changes to ultimately be more open for newcomers. There's
simply far too much to learn in Spark Core, and such naming conventions where
`isFinished` should've been `isCompleted` instead (following the event
`CompleteEvent` sent later) don't make it any easier.
Thanks a lot for helping me find the right way! I'm greatly indebted for
the effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
