GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/13517
[SPARK-14839][SQL] Support for other types as option in OPTIONS clause
## What changes were proposed in this pull request?
Currently, Scala API supports to take options with the types, `String`,
`Long`, `Double` and `Boolean` and Python API also supports other types.
This PR adds the support for other types (string, boolean, double and
integer) as options so that support the options for data sources in a
consistent way.
While looking up other options, I realised that `samplingRatio`
documentation is missing. So, I added the documentation.
Also, `TODO add bucketing and partitioning.` was removed because it was
resolved in
https://github.com/apache/spark/commit/24bea000476cdd0b43be5160a76bc5b170ef0b42
## How was this patch tested?
Unit test in `MetastoreDataSourcesSuite.scala`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-14839
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13517.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13517
----
commit ba014eee8f910262b6db2d9ec4fe84478890a03c
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-06-05T06:26:49Z
Support for other types in option clause in SQL Syntax
commit 1f94ca4a47ae3ae99d41551466f42d4ce96c3f07
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-06-05T06:38:44Z
Update commnets for a new function
commit 1833d4f66a8c80314f3075d0088cc1903f6ed16f
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-06-05T07:07:55Z
Add a todo
commit 1e6bdd3a3b6e303006004bd893b6bbe20561016f
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-06-05T07:22:16Z
Add override
commit 905bdc594ebbb658d9392585af3a0ab7206841e1
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-06-05T07:27:12Z
Change documentation for the correct explanation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
