Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13517#discussion_r65835938
  
    --- Diff: python/pyspark/sql/readwriter.py ---
    @@ -180,6 +180,9 @@ def json(self, path, schema=None, 
primitivesAsString=None, prefersDecimal=None,
             :param path: string represents path to the JSON dataset,
                          or RDD of Strings storing JSON objects.
             :param schema: an optional :class:`StructType` for the input 
schema.
    +        :param samplingRatio: sets the ratio for sampling and reading the 
input data to infer
    --- End diff --
    
    Ah, I see. It does not affect the actual I/O but just drops some and then 
try to infer the schema. 
    I will remove the change.
    
    BTW, actually, I have found another one 
[`mergeSchema`](https://github.com/apache/spark/blob/431542765785304edb76a19885fbc5f9b8ae7d64/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala#L148-L152)
 option in Parquet data source, which I guess should be located in 
`ParquetOptions`. Can this be done here together maybe..?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to