Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13650#discussion_r70603646
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -44,7 +44,8 @@ private[shared] object SharedParamsCodeGen {
" probabilities. Note: Not all models output well-calibrated
probability estimates!" +
" These probabilities should be treated as confidences, not
precise probabilities",
Some("\"probability\"")),
- ParamDesc[String]("varianceCol", "Column name for the biased sample
variance of prediction"),
+ ParamDesc[String]("varianceCol", "Column name for the biased sample
variance of prediction",
+ Some("\"variance\"")),
--- End diff --
I'd like this change, although we did not output variance column by default
at #8866. Consider that we have default value for ```probabilityCol```, I think
it's ok to add default value for ```varianceCol```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
