Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r73333286
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -112,6 +152,11 @@ case class Filter(condition: Expression, child:
LogicalPlan)
.filterNot(SubqueryExpression.hasCorrelatedSubquery)
child.constraints.union(predicates.toSet)
}
+
+ override def sql: String = child match {
+ case _: Aggregate => s"${child.sql} HAVING ${condition.sql}"
+ case _ => s"${child.sql} WHERE ${condition.sql}"
--- End diff --
The only difference is `HAVING` vs `WHERE`, right?
Mind extracting the small difference out and doing the following instead:
```
val havingOrWhere = ???
s"${child.sql} $havingOrWhere ${condition.sql}"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
