Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14435#discussion_r73334011
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -692,11 +864,17 @@ case class LocalLimit(limitExpr: Expression, child: 
LogicalPlan) extends UnaryNo
         }
         child.statistics.copy(sizeInBytes = sizeInBytes)
       }
    +
    +  override def sql: String = child.sql
     }
     
     case class SubqueryAlias(alias: String, child: LogicalPlan) extends 
UnaryNode {
     
       override def output: Seq[Attribute] = 
child.output.map(_.withQualifier(Some(alias)))
    +
    +  override def sql: String = child match {
    +    case _ => if (child.sql.equals(alias)) child.sql else s"(${child.sql}) 
AS $alias"
    --- End diff --
    
    Why do you pattern match here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to