GitHub user wangyum opened a pull request:

    https://github.com/apache/spark/pull/16079

    [SPARK-18645][Deploy] Fix spark-daemon.sh arguments error lead to throws 
Unrecognized option

    ## What changes were proposed in this pull request?
    
    spark-daemon.sh will lost single quotes around after #15338. as follows:
    ```
    execute_command nice -n 0 bash 
/opt/cloudera/parcels/SPARK-2.1.0-cdh5.4.3.d20161129-21.04.38/lib/spark/bin/spark-submit
 --class org.apache.spark.sql.hive.thriftserver.HiveThriftServer2 --name Thrift 
JDBC/ODBC Server --conf spark.driver.extraJavaOptions=-XX:+UseG1GC 
-XX:-HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp
    ```
    With this fix, as follows:
    ```
    execute_command nice -n 0 bash 
/opt/cloudera/parcels/SPARK-2.1.0-cdh5.4.3.d20161129-21.04.38/lib/spark/bin/spark-submit
 --class org.apache.spark.sql.hive.thriftserver.HiveThriftServer2 --name 
'Thrift JDBC/ODBC Server' --conf 'spark.driver.extraJavaOptions=-XX:+UseG1GC 
-XX:-HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp'
    ```
    
    ## How was this patch tested?
    
    - Manual tests 
    - Build the package and start-thriftserver.sh with `--conf 
'spark.driver.extraJavaOptions=-XX:+UseG1GC -XX:-HeapDumpOnOutOfMemoryError 
-XX:HeapDumpPath=/tmp'`
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyum/spark SPARK-18645

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16079
    
----
commit 563645f9fe6e999adc2ee22422cfb236278f3c10
Author: Yuming Wang <wgy...@gmail.com>
Date:   2016-11-30T10:00:13Z

    Fix Unrecognized option

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to