Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16079#discussion_r90221689
--- Diff: sbin/spark-daemon.sh ---
@@ -124,9 +124,8 @@ if [ "$SPARK_NICENESS" = "" ]; then
fi
execute_command() {
- local command="$@"
if [ -z ${SPARK_NO_DAEMONIZE+set} ]; then
- nohup -- $command >> $log 2>&1 < /dev/null &
+ nohup -- "$@" >> $log 2>&1 < /dev/null &
--- End diff --
It's OK by me, but why remove the local?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
