Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16154#discussion_r91140911
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala
---
@@ -158,7 +158,7 @@ private[sql] object SQLUtils extends Logging {
val dis = new DataInputStream(bis)
val num = SerDe.readInt(dis)
Row.fromSeq((0 until num).map { i =>
- doConversion(SerDe.readObject(dis), schema.fields(i).dataType)
+ doConversion(SerDe.readObject(dis, jvmObjectTracker = null),
schema.fields(i).dataType)
--- End diff --
I think this one is safe because this is called on the output from the R
UDF and the R UDF is assumed to return native types (i.e. no references to
other JVM objects)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
