Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16154#discussion_r91136911
  
    --- Diff: core/src/main/scala/org/apache/spark/api/r/RRunner.scala ---
    @@ -152,7 +152,7 @@ private[spark] class RRunner[U](
               dataOut.writeInt(mode)
     
               if (isDataFrame) {
    -            SerDe.writeObject(dataOut, colNames)
    +            SerDe.writeObject(dataOut, colNames, jvmObjectTracker = null)
    --- End diff --
    
    I think this change is fine as we are only writing out an array of string 
-- the other thing we can do is replace the code here and not call SerDe -- but 
instead just write out the code for writing an array of strings. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to