Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/16250#discussion_r91860470
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -333,16 +333,16 @@ class DAGScheduler(
// (so we don't unnecessarily re-compute that data).
val serLocs =
mapOutputTracker.getSerializedMapOutputStatuses(shuffleDep.shuffleId)
val locs = MapOutputTracker.deserializeMapStatuses(serLocs)
- (0 until locs.length).foreach { i =>
- if (locs(i) ne null) {
- // locs(i) will be null if missing
- stage.addOutputLoc(i, locs(i))
+ locs.zipWithIndex
+ .filter { case (status, _) => status != null } // null if missing
+ .foreach { case (ms, idx) =>
+ stage.addOutputLoc(idx, ms)
}
- }
} else {
// Kind of ugly: need to register RDDs with the cache and map output
tracker here
// since we can't do it in the RDD constructor because # of
partitions is unknown
- logInfo("Registering RDD " + rdd.id + " (" + rdd.getCreationSite +
")")
+ logInfo(s"Registering RDD ${rdd.id} (partitions:
${rdd.partitions.length}, " +
--- End diff --
Yes, but it was because I think it's important at this "stage". Do you
think I should remove the partition-related addition?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
