Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16250
Thanks @srowen for the review! I do understand your point and remember you
and @rxin have always been telling me that I should not touch code unless
there's a need for a change.
But the more I'm with the code the more I think there'd be more
contributions if the code were even slightly more readable. I'm still having
troubles getting the gist of it (but am closer).
Spark in general is very tricky to get the hang of and when the code is
unnecessarily complex (like doing traversing, filtering and branching in a
convoluted way) the more functional bits could certainly help the code, me and
the community. That's my hope.
That's also why I'm sending very small changes to get myself going with
more ease with the code (and get more comfortable with what's acceptable). All
in all, I don't think I'm ready for heavier contributions yet, but I do think
I'm closer and will soon be. Your help and patience have helped a lot. Thanks
(and don't worry if you have to reject my changes).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
