Github user uncleGen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17144#discussion_r104570057
  
    --- Diff: 
core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala 
---
    @@ -494,7 +494,9 @@ class BlockManagerProactiveReplicationSuite extends 
BlockManagerReplicationBehav
     
         val newLocations = master.getLocations(blockId).toSet
         logInfo(s"New locations : $newLocations")
    -    assert(newLocations.size === replicationFactor)
    +    eventually(timeout(5 seconds), interval(10 millis)) {
    +      assert(newLocations.size === replicationFactor)
    +    }
         // there should only be one common block manager between initial and 
new locations
    --- End diff --
    
    continually check a condition and then timeout after 5 seconds


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to