Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17144#discussion_r104619252
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
---
@@ -494,7 +494,9 @@ class BlockManagerProactiveReplicationSuite extends
BlockManagerReplicationBehav
val newLocations = master.getLocations(blockId).toSet
logInfo(s"New locations : $newLocations")
- assert(newLocations.size === replicationFactor)
+ eventually(timeout(5 seconds), interval(10 millis)) {
+ assert(newLocations.size === replicationFactor)
--- End diff --
IMHO, we can not remove the first sleep. For example there are three
blockmanager A, B, C. When we stats to remove BM-A, all blocks in BM-A will be
replicated to BM-B and BM-C. We can not remove BM-B immediately or too fast, as
there may be no enough time to do replication and new block info may can not be
registered to master properly. So, we should instead give a little more time to
sleep just like my fist fix. But it is OK to remove the second sleep.
@kayousterhout Tell me if i was missing something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
