Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17615#discussion_r111068037
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -124,13 +124,6 @@ private[sql] class HiveSessionCatalog(
}
private def lookupFunction0(name: FunctionIdentifier, children:
Seq[Expression]): Expression = {
- // TODO: Once lookupFunction accepts a FunctionIdentifier, we should
refactor this method to
- // if (super.functionExists(name)) {
- // super.lookupFunction(name, children)
- // } else {
- // // This function is a Hive builtin function.
- // ...
- // }
--- End diff --
`LookupFunction` already accepts `FunctionIdentifier`, but we are unable to
do it using the above way because `functionExists` does not consider the
difference among Hive built-in, Spark temporary and permanent functions. More
following clean-ups are needed. Will try to do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
