Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17615#discussion_r111068193
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -59,17 +60,13 @@ case class CreateFunctionCommand(
// We first load resources and then put the builder in the function
registry.
// Please note that it is allowed to overwrite an existing temp
function.
catalog.loadFunctionResources(resources)
- val info = new ExpressionInfo(className, functionName)
- val builder = catalog.makeFunctionBuilder(functionName, className)
- catalog.createTempFunction(functionName, info, builder,
ignoreIfExists = false)
+ catalog.registerFunction(func, ignoreIfExists = false)
} else {
// For a permanent, we will store the metadata into underlying
external catalog.
// This function will be loaded into the FunctionRegistry when a
query uses it.
// We do not load it into FunctionRegistry right now.
// TODO: should we also parse "IF NOT EXISTS"?
--- End diff --
Should we support it? @cloud-fan @yhuai @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
