Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19065#discussion_r135653044
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -262,6 +262,9 @@ class DecisionTreeClassifierSuite
assert(Vectors.dense(rawPred.toArray.map(_ / sum)) === probPred,
"probability prediction mismatch")
}
+
+ ProbabilisticClassifierSuite.probabilisticClassifierGenericTest[
--- End diff --
We should use a more descriptive name for this test. How about
`ProbabilisticClassifierSuite.testPredictMethods`? @jkbradley may have other
suggestions too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
