Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19065#discussion_r135656421
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -91,4 +94,54 @@ object ProbabilisticClassifierSuite {
"thresholds" -> Array(0.4, 0.6)
)
+ def probabilisticClassifierGenericTest[
+ FeaturesType,
+ M <: ProbabilisticClassificationModel[FeaturesType, M]](
+ model: M, testData: Dataset[_]): Unit = {
+
+ val allColModel = model.copy(ParamMap.empty)
+ .setRawPredictionCol("rawPredictionAll")
+ .setProbabilityCol("probabilityAll")
+ .setPredictionCol("predictionAll")
+ val allColResult = allColModel.transform(testData)
+
+ for (rawPredictionCol <- Seq("", "rawPredictionSingle")) {
+ for (probabilityCol <- Seq("", "probabilitySingle")) {
--- End diff --
Just to confirm, does setting `probabilityCol`, `rawPredictionCol`,
`predictionCol` to empty strings work here because expressions like
`$(probabilityCol)` (used in
[ProbabilisticClassifier.scala](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala#L115))
return the String value of probabilityCol?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
