Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19112#discussion_r136726519
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
    @@ -200,7 +202,7 @@ class SourceProgress protected[sql](
      */
     @InterfaceStability.Evolving
     class SinkProgress protected[sql](
    -    val description: String) extends Serializable {
    --- End diff --
    
    Yes. Please refer here, https://github.com/databricks/scala-style-guide
    ```scala
    class Foo(
        val param1: String,  // 4 space indent for parameters
        val param2: String,
        val param3: Array[Byte])
      extends FooInterface  // 2 space indent here
      with Logging {
    
      def firstMethod(): Unit = { ... }  // blank line above
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to