Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19112#discussion_r136892336
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
@@ -200,7 +202,7 @@ class SourceProgress protected[sql](
*/
@InterfaceStability.Evolving
class SinkProgress protected[sql](
- val description: String) extends Serializable {
--- End diff --
not a committer but would like to leave this suggestion :
- codestyle changes are orthogonal to the motive of the PR and should be
done separately. Generally, every PR should address one problem and not have
changes unrelated to it. In event of revert or bisecting commits to pin-point
regression, following this practice helps a lot.
- It would be beneficial to see why checkstyle does not catch such
instances and fix that (along with making all such instances consistent with
the rules). Otherwise this would be a one off fix and we would continue to pile
up similar inconsistencies in future development without anyone realising this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
