Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19116#discussion_r136898192
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -19,7 +19,9 @@ package org.apache.spark.repl
import java.io.BufferedReader
+// scalastyle:off println
import scala.Predef.{println => _, _}
+// scalastyle:on println
--- End diff --
This actually looks valid though. If I manually add ` import
scala.Predef.{println => _, _}` somewhere not here, for example, `SQLConf` in
the current master:
```
[error]
.../spark/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:26:21:
Are you sure you want to println? If yes, wrap the code block with
[error] // scalastyle:off println
[error] println(...)
[error] // scalastyle:on println
[error]
.../spark/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:26:0:
scala.Predef. is in wrong order relative to scala.collection.immutable.
```
It looks recognising this as an error. Looks 1.0.0 fixes an issue about
those style checking and detection. We might have to fix `println` token
checker rule but I guess this should be orthogonal anyway.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
