Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19116#discussion_r136745412
--- Diff: scalastyle-config.xml ---
@@ -268,10 +268,7 @@ This file is divided into 3 sections:
</check>
<!-- SPARK-16877: Avoid Java annotations -->
- <check customId="OverrideJavaCase" level="error"
class="org.scalastyle.scalariform.TokenChecker" enabled="true">
- <parameters><parameter name="regex">^Override$</parameter></parameters>
- <customMessage>override modifier should be used instead of
@java.lang.Override.</customMessage>
- </check>
+ <check level="error"
class="org.scalastyle.scalariform.OverrideJavaChecker" enabled="true"></check>
--- End diff --
This removes the workaround we used and use
`org.scalastyle.scalariform.OverrideJavaChecker` -
`https://github.com/scalastyle/scalastyle/issues/214`.
I manually tested with `@Override`:
Before:
```
[error] ...:435:3: override modifier should be used instead of
@java.lang.Override.
```
After:
```
[error] ...:435:2: override keyword should be used instead of
@java.lang.Override
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
