Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r138794058 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -75,67 +76,131 @@ public static boolean unaligned() { return unaligned; } + public static int getInt(MemoryBlock object, long offset) { --- End diff -- Do you want to move them (i.e. methods with `MemoryBlock` argument) into `unsafe/memory/MemoryBlock.java`?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org