Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r138794370
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java ---
@@ -59,6 +60,18 @@ public static int hashUnsafeWords(Object base, long
offset, int lengthInBytes, i
return fmix(h1, lengthInBytes);
}
+ public static int hashUnsafeBytes(MemoryBlock base, long offset, int
lengthInBytes, int seed) {
--- End diff --
It makes sense. Is it better to add postfix `MB` to another version of the
method?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
