Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19208#discussion_r139556318
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -82,7 +82,10 @@ private[shared] object SharedParamsCodeGen {
"all instance weights as 1.0"),
ParamDesc[String]("solver", "the solver algorithm for optimization",
finalFields = false),
ParamDesc[Int]("aggregationDepth", "suggested depth for
treeAggregate (>= 2)", Some("2"),
- isValid = "ParamValidators.gtEq(2)", isExpertParam = true))
+ isValid = "ParamValidators.gtEq(2)", isExpertParam = true),
+ ParamDesc[Boolean]("collectSubModels", "whether to collect sub
models when tuning fitting",
--- End diff --
Suggestion: reword "whether to collect sub models when tuning fitting" -->
"whether to collect a list of sub-models trained during tuning"
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
